Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated: Repeater's grid() method can except closure as parameter #14630

Open
wants to merge 17 commits into
base: 4.x
Choose a base branch
from

Conversation

tjodalv
Copy link
Contributor

@tjodalv tjodalv commented Oct 25, 2024

Description

This is a follow up of #14553

Hi! Thanks for the feedback, and apologies for any oversight on our end regarding the contribution guidelines. I've reviewed the notes, and I've created a new pull request where:

  • The 'auto' functionality has been removed, as suggested.
  • The logic for the ->grid() function has been adjusted so that calling ->grid() multiple times merges onto the array, maintaining the original behavior. Additionally, ->grid() now accepts a closure. Closure will be executed last allowing it to override any breakpoint value that is being set previously.

I'm looking forward to any further feedback, and thank you for considering this improvement for v4!

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin changed the base branch from 3.x to 4.x October 26, 2024 07:40
@danharrin danharrin added this to the v4 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants