Add in new KeyMgmt threat and tests #406
Open
+34
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddie-knight
previously approved these changes
Sep 22, 2024
Comment on lines
+111
to
+112
| threats: | ||
| - CCC.KeyMgmt.TH01 |
There was a problem hiding this comment.
I don't think we should map common-controls to specific-threats
| @@ -10,7 +10,7 @@ threats: | |||
| - TA0005 | |||
| - T1562 | |||
| - id: CCC.TH02 | |||
| title: Vendor-hosted keys are compromised | |||
| title: Vendor-hosted keys are compromised #TODO: Should this be in the crypto service? | |||
There was a problem hiding this comment.
Yeah that makes sense to me for this one.
| @@ -32,7 +32,7 @@ threats: | |||
| - TA009 | |||
| - T1557 | |||
| - id: CCC.TH04 | |||
| title: Attacker encrypts data with client-managed keys | |||
| title: Attacker encrypts data with client-managed keys #TODO: Should this be in the crypto service? | |||
There was a problem hiding this comment.
This seems to be a matter of a non-KMS asset being compromised, right? So there is a threat to any service that allows the key to perform destructive action.
Pivot question... Should this instead be "Client managed keys are compromised" ?
mlysaght2017
dismissed stale reviews from damienjburks and eddie-knight
via
d2f7052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eddie-knight - added in todos as well on two threats related to KMS that are currently down as common, but may be better shifted to KMS specific threats - let me know your thoughts.