Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docusaurus #138

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Add docusaurus #138

merged 8 commits into from
Jun 25, 2024

Conversation

TheJuanAndOnly99
Copy link
Member

@TheJuanAndOnly99 TheJuanAndOnly99 commented Mar 20, 2024

#133 This PR adds Docusaurus v3.

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for lucky-concha-f3599f ready!

Name Link
🔨 Latest commit 1eaae47
🔍 Latest deploy log https://app.netlify.com/sites/lucky-concha-f3599f/deploys/663e1fa4682a450008dd4a37
😎 Deploy Preview https://deploy-preview-138--lucky-concha-f3599f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@psmulovics
Copy link

@mimiflynn, FYI

Copy link

linux-foundation-easycla bot commented Apr 3, 2024

CLA Missing ID CLA Not Signed

ignore = "git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../{docs,website}/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheJuanAndOnly99 , we tried quite a few combination of this - and ended up just by using /bin/false . If you figure out a working setup (that works for the draft pages too and for normal, etc), I am super interested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @psmulovics not sure I understand what you mean by draft vs normal pages. The objective here is to only run Netlify on PRs that contain changes to the docs and website folders.

@maoo
Copy link
Member

maoo commented Jun 25, 2024

@DovOps @rocketstack-matt - could you please review this PR, so we can move forward with the merge?

@maoo maoo marked this pull request as ready for review June 25, 2024 12:28
@rocketstack-matt
Copy link
Member

@DovOps @rocketstack-matt - could you please review this PR, so we can move forward with the merge?

Is the intent just to get the docs project in the build, as obviously the docs themselves are missing other than the front page? If so the setup looks fine to me, but I can't merge as I don't have write access to the repo. Which raises the question should we be adding CODEOWNERS into this repo and broadening the maintainer list? @maoo / @DovOps

@maoo
Copy link
Member

maoo commented Jun 25, 2024

@DovOps @rocketstack-matt - could you please review this PR, so we can move forward with the merge?

Is the intent just to get the docs project in the build, as obviously the docs themselves are missing other than the front page? If so the setup looks fine to me, but I can't merge as I don't have write access to the repo. Which raises the question should we be adding CODEOWNERS into this repo and broadening the maintainer list? @maoo / @DovOps

Good points. Here's my proposal:

  1. Make Matt a TraderX Maintainer (@DovOps - please lmk if you agree and I'll go ahead with permission changes)
  2. Matt raises Pull Request around CODEOWNERS
  3. Matt raises an issue to port documentation from github READMEs to Docusaurus (and update links into other collaterals); this issue could be a Good First Issue

Thoughts?

@DovOps
Copy link
Contributor

DovOps commented Jun 25, 2024

@maoo I suggest we merge this - good with perm changes. And we can make additional changes once this is properly in the build

@maoo maoo merged commit 894a2eb into main Jun 25, 2024
4 of 5 checks passed
@maoo maoo deleted the docs-website branch June 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants