-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled PWAs #188
base: master
Are you sure you want to change the base?
Enabled PWAs #188
Conversation
Added necessary filesystem access for installing Progressive Web Apps. I got a warning when accessing various google services (like Google Docs) about how I needed to allow this access in order to install the PWA. I did. It worked. Thought I'd contribute that upstream. Thanks for this flatpak - love it!
Started test build 20105 |
Build 20105 successful
|
I'm using it on a fresh install of Ubuntu Jammy LTS 22.04 after running unsnap. |
Good suggestion. I'm going to look into if this can be done without requiring any "--filesystem" permissions; maybe a symlink to /export/share/applications or something, the flatpak docs are not very clear about this. |
AFAIK this will not work. According to the #91 (comment) the permissions must look like this:
Meanwhile in your commit they look like this:
I can confirm this since I tested it on my installation. UPD: Already noted by @Aqua1ung 😅: |
I agree. Unless we can think of something more elegant, using .local and the :create suffix is the best option for now. |
Will uninstalling the Chrome flatpak remove previously installed PWAs? |
@averms Currently, no. Edit: Forgot to mention, this is a good question. We would need to figure out how to get the flatpak to export desktop files from within the sandbox. (Or run a uninstall script with a hook, which kind of defeats the point of flatpak) I have yet to do any experimenting, but docs.flatpak.org only mentions exporting desktop files at build time. Unless some experienced flatpak-er knows otherwise, it seems like |
https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.DynamicLauncher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would improve overall experience, when the user don't have to set this by himself via command-line or with 'warehouse'.
Since this change is now approved if you are to merge them, please mind #188 (comment) |
@Danik1601 that's a good point, I have added the it with Warehouse and without the ':create' suffix. |
Added necessary filesystem access for installing Progressive Web Apps. I got a warning when accessing various google services (like Google Docs) about how I needed to allow this access in order to install the PWA. I did. It worked. Thought I'd contribute that upstream. Thanks for this flatpak - love it!