Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Rnote and Installer for Windows Arm64 #1211

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

OB0NE
Copy link

@OB0NE OB0NE commented Sep 8, 2024

Following @Doublonmousse 's advice in #1209 ,I made some adjustments to the former request #1209 to add support for building Rnote on Windows ARM64 while not breaking the x86 build process. architecture. The changes include:

  1. Added a new Meson option 'win-arm64-build-environment-path' in meson_options.txt to specify the path for the ARM64 build environment. I also changed the meson.build to detect architecture and chose build environment accordingly.

  2. Modified cargo_build.py to detect the system architecture and set appropriate Rust flags:

    • Added platform detection for Windows ARM64.
    • Set '-C linker=clang' flag for ARM64 builds on Windows.
  3. Updated rnote_inno.iss.in to include ARM64 architecture support for the Windows installer.

And the issue about black borders is fixed. See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7692.

I’ve only been able to test the build on a Microsoft Surface Pro 11, so I'm unsure how it will perform on other ARM devices.

add options for windows arm64 build environment path
Add support for arm64 architecture.
Detecting architecture.
Detecting architecture.
Detecting architecture(the former change was incomplete)
Add windows arm build instructions
@flxzt
Copy link
Owner

flxzt commented Sep 8, 2024

Maybe I am wrong, but I don't directly see the need for the win-arm64-build-environment-path meson variable. Won't win-build-environment-path already cover this? One would just need to configure the project to point to the clangarm64 environment when building on ARM.

@OB0NE
Copy link
Author

OB0NE commented Sep 9, 2024

Maybe I am wrong, but I don't directly see the need for the win-arm64-build-environment-path meson variable. Won't win-build-environment-path already cover this? One would just need to configure the project to point to the clangarm64 environment when building on ARM.

Do you mean git rid of the win-arm64-build-environment-path , and build like this?

meson setup --prefix=/usr -Dwin-build-environment-path=C:\msys64\clangarm64 _mesonbuild

@flxzt
Copy link
Owner

flxzt commented Sep 9, 2024

Do you mean git rid of the win-arm64-build-environment-path , and build like this?

meson setup --prefix=/usr -Dwin-build-environment-path=C:\msys64\clangarm64 _mesonbuild

Yes exactly!

delete option: win-arm64-build-environment-path
delete option win-arm64-build-environment-path
@OB0NE
Copy link
Author

OB0NE commented Sep 10, 2024

Do you mean git rid of the win-arm64-build-environment-path , and build like this?

meson setup --prefix=/usr -Dwin-build-environment-path=C:\msys64\clangarm64 _mesonbuild

Yes exactly!

I've deleted the 'win-arm64-build-environment-path' and changed the build instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants