-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Rnote and Installer for Windows Arm64 #1211
base: main
Are you sure you want to change the base?
Conversation
add options for windows arm64 build environment path
Add support for arm64 architecture.
Detecting architecture.
Detecting architecture.
Detecting architecture(the former change was incomplete)
Add windows arm build instructions
Maybe I am wrong, but I don't directly see the need for the |
Do you mean git rid of the
|
Yes exactly! |
delete option: win-arm64-build-environment-path
delete option win-arm64-build-environment-path
I've deleted the 'win-arm64-build-environment-path' and changed the build instructions. |
Following @Doublonmousse 's advice in #1209 ,I made some adjustments to the former request #1209 to add support for building Rnote on Windows ARM64 while not breaking the x86 build process. architecture. The changes include:
Added a new Meson option 'win-arm64-build-environment-path' in meson_options.txt to specify the path for the ARM64 build environment. I also changed the meson.build to detect architecture and chose build environment accordingly.
Modified cargo_build.py to detect the system architecture and set appropriate Rust flags:
Updated rnote_inno.iss.in to include ARM64 architecture support for the Windows installer.
And the issue about black borders is fixed. See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7692.
I’ve only been able to test the build on a Microsoft Surface Pro 11, so I'm unsure how it will perform on other ARM devices.