Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Pr into pr: fix migrations for sqlite #374

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

katrogan
Copy link
Contributor

no idea how rollback even works for sqlite since dropping columns appears to be very convoluted

kumare3 and others added 13 commits March 10, 2022 21:49
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
@kumare3
Copy link
Contributor

kumare3 commented Mar 20, 2022

I do not like this PR

@katrogan
Copy link
Contributor Author

@kumare3 do you dislike the uuid in place of autoincrement id or the sqlite vs postgres specific migrations?

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Base automatically changed from refactors to master March 24, 2022 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants