Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Store additional claims in the QueryUserInfoFromAccessToken path #512

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Jan 11, 2023

Signed-off-by: Haytham Abuelfutuh [email protected]

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #512 (e89a049) into master (1ccd59c) will decrease coverage by 0.01%.
The diff coverage is 52.17%.

❗ Current head e89a049 differs from pull request most recent head e1134a4. Consider uploading reports for the commit e1134a4 to get more accurate results

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   60.04%   60.03%   -0.02%     
==========================================
  Files         168      168              
  Lines       15010    15031      +21     
==========================================
+ Hits         9013     9024      +11     
- Misses       5203     5210       +7     
- Partials      794      797       +3     
Flag Coverage Δ
unittests 60.03% <52.17%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
auth/handlers.go 36.17% <52.17%> (+1.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant