Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

V1.1.88.1 patch #561

Open
wants to merge 3 commits into
base: release-v1.1.88
Choose a base branch
from
Open

V1.1.88.1 patch #561

wants to merge 3 commits into from

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented May 11, 2023

TL;DR

This is a PR to pull in the column fixes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

eapolinario and others added 3 commits May 10, 2023 13:15
…ary (#554)

* Add migration to turn `parent_id` column into `bigint` only if necessary

Signed-off-by: eduardo apolinario <[email protected]>

* Migrations to handle the change of `parent_id` column in `node_executions` table

Signed-off-by: eduardo apolinario <[email protected]>

* Add unit test

Signed-off-by: eduardo apolinario <[email protected]>

* More coverage

Signed-off-by: eduardo apolinario <[email protected]>

* Create index outside transaction

Signed-off-by: eduardo apolinario <[email protected]>

---------

Signed-off-by: eduardo apolinario <[email protected]>
Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #561 (7239413) into release-v1.1.88 (eb695b1) will decrease coverage by 0.38%.
The diff coverage is 12.06%.

@@                 Coverage Diff                 @@
##           release-v1.1.88     #561      +/-   ##
===================================================
- Coverage            58.85%   58.48%   -0.38%     
===================================================
  Files                  170      170              
  Lines                16068    16184     +116     
===================================================
+ Hits                  9457     9465       +8     
- Misses                5777     5883     +106     
- Partials               834      836       +2     
Flag Coverage Δ
unittests 58.48% <12.06%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repositories/config/migrations.go 2.68% <12.06%> (+1.54%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants