Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Additional catalog client functionality for cache eviction #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MorpheusXAUT
Copy link
Contributor

TL;DR

Added extra methods for accessing and removing artifact data to catalog client.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

The new ByArtifactTag methods were added to allow for easier access to reservations from flyteadmin (which retrieves the artifact tag from its stored metadata without having to access the stored artifact to generate a catalog.Key).
Additional functionality for deleting artifacts has been added as well.

Tracking Issue

flyteorg/flyte#2867

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #301 (79e9a15) into master (8efeda7) will increase coverage by 1.18%.
The diff coverage is n/a.

❗ Current head 79e9a15 differs from pull request most recent head bda210e. Consider uploading reports for the commit bda210e to get more accurate results

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   62.35%   63.53%   +1.18%     
==========================================
  Files         147      145       -2     
  Lines       11809     9334    -2475     
==========================================
- Hits         7363     5930    -1433     
+ Misses       3882     2859    -1023     
+ Partials      564      545      -19     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/pluginmachinery/catalog/client.go 87.50% <ø> (-0.60%) ⬇️
go/tasks/pluginmachinery/flytek8s/pod_helper.go 79.13% <0.00%> (-4.94%) ⬇️
go/tasks/plugins/array/inputs.go 83.33% <0.00%> (-4.91%) ⬇️
.../pluginmachinery/internal/webapi/plugin_context.go 50.00% <0.00%> (-3.85%) ⬇️
go/tasks/plugins/k8s/sagemaker/plugin.go 74.07% <0.00%> (-3.20%) ⬇️
go/tasks/plugins/array/core/state.go 69.13% <0.00%> (-2.85%) ⬇️
go/tasks/plugins/hive/config/config.go 33.33% <0.00%> (-2.39%) ⬇️
go/tasks/plugins/presto/config/config.go 33.33% <0.00%> (-2.39%) ⬇️
go/tasks/plugins/array/core/metadata.go 80.00% <0.00%> (-2.23%) ⬇️
go/tasks/pluginmachinery/catalog/response.go 42.85% <0.00%> (-2.15%) ⬇️
... and 123 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Nick Müller added 2 commits January 4, 2023 16:04
Extended reservation retrieval to allow querying via artifact tag in catalog client interface

Signed-off-by: Nick Müller <[email protected]>
Added method to delete catalog artifact by ID

Signed-off-by: Nick Müller <[email protected]>
@MorpheusXAUT
Copy link
Contributor Author

Rebased onto current master branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant