Fix frozen string literal issues part 2 #711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2024
chaadow
force-pushed
the
fix_ruby_frozen_string_literals
branch
from
1a086dc
to
2555efc
Compare
|
Ok sorry, I managed to find the shared config ( i was a bit lost with As we've said in the previous PR, the idea is to manually enable it gem by gem, and once we feel comfortable we make it common to every gem in the shared CI config. (Right now, tests are failing because the dependent PRs are not yet merged/released) |
|
I think a good idea would be to add timeouts on the CI, it's taking a bit long i'm sorry. I will do tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #709
After running tests locally I managed to fix all of the frozen string literals issues.
This PR however depends on
fog-coreandfog-xmlbeing fixed ( I will create separate PRs on those repos)EDIT: here are the 2 PRs:
It's worth mentioning that on
fog-coreandfog-xml, I will just fix just enough to make the tests green hereI haven't yet run the tests on those repos.
@geemus What do you think? Do you mind providing me with a simple github action .yml file in which i can enable RUBYOPT
here is the command I run locally:
bundle exec rake RUBYOPT="--enable-frozen-string-literal"