Skip to content

Commit

Permalink
Fix save method on existing security group
Browse files Browse the repository at this point in the history
  • Loading branch information
KevinLoiseau committed Oct 31, 2018
1 parent 1fde7d8 commit 6d1c7f6
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions lib/fog/azurerm/models/network/network_security_group.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def self.parse(nsg)
def save
requires :name, :location, :resource_group

security_rules_to_hashes!
validate_security_rules(security_rules) unless security_rules.nil?
nsg = service.create_or_update_network_security_group(resource_group, name, location, security_rules, tags)
merge_attributes(Fog::Network::AzureRM::NetworkSecurityGroup.parse(nsg))
Expand Down Expand Up @@ -75,6 +76,18 @@ def remove_security_rule(security_rule_name)

private

def security_rules_to_hashes!
return unless security_rules.is_a? Array

self.security_rules = security_rules.map do |rule|
if rule.is_a? NetworkSecurityRule
get_hash_from_object(rule)['attributes']
else
rule
end
end
end

def validate_security_rules(security_rules)
if security_rules.is_a?(Array)
security_rules.each do |sr|
Expand Down

0 comments on commit 6d1c7f6

Please sign in to comment.