Add Fog Support for Azure Stack #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingosummer
commented
May 28, 2018
bingosummer
commented
- Support managing storage data in Azure Stack. But it still can't create/delete storage account in Azure Stack. Fixes Add Fog Support for Azure Stack #367.
- Upgrade the version of mime-types gem. Fixes Bundler could not find compatible versions for gem "mime-types" #359.
- Add user agent prefix in the storage requests.
- Update the dependency azure-storage.
houndci-bot
reviewed
May 28, 2018
|
|
||
| puts "Deleted container: #{container.destroy}" | ||
| puts "Deleted test container: #{test_container.destroy}" | ||
| rescue => ex |
There was a problem hiding this comment.
Style/RescueStandardError: Avoid rescuing without specifying an error class.
test/integration/blob_azure_stack.rb
Outdated
| ######################################################################################################################## | ||
|
|
||
| time = current_time | ||
| resource_group_name = azure_credentials['resource_group_name'] |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - resource_group_name.
lib/fog/azurerm/storage.rb
Outdated
| unless @environment == ENVIRONMENT_AZURE_STACK | ||
| client_options[:storage_dns_suffix] = storage_endpoint_suffix(@environment)[1..-1] | ||
| else | ||
| client_options[:storage_dns_suffix] = @azure_storage_dns_suffix.nil? ? "local.azurestack.external" : @azure_storage_dns_suffix |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
lib/fog/azurerm/storage.rb
Outdated
| :storage_access_key => @azure_storage_access_key, | ||
| :user_agent_prefix => telemetry | ||
| } | ||
| unless @environment == ENVIRONMENT_AZURE_STACK |
There was a problem hiding this comment.
Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.
Style/UnlessElse: Do not use unless with else. Rewrite these with the positive case first.
lib/fog/azurerm/storage.rb
Outdated
| client_options = { | ||
| :storage_account_name => @azure_storage_account_name, | ||
| :storage_access_key => @azure_storage_access_key, | ||
| :user_agent_prefix => telemetry |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
lib/fog/azurerm/storage.rb
Outdated
| azure_client.storage_blob_host = get_blob_endpoint(@azure_storage_account_name, true, @environment) | ||
| client_options = { | ||
| :storage_account_name => @azure_storage_account_name, | ||
| :storage_access_key => @azure_storage_access_key, |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
lib/fog/azurerm/storage.rb
Outdated
| storage_access_key: @azure_storage_access_key) | ||
| azure_client.storage_blob_host = get_blob_endpoint(@azure_storage_account_name, true, @environment) | ||
| client_options = { | ||
| :storage_account_name => @azure_storage_account_name, |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Closed
5 tasks
|
@bilal-naeem-confiz Please help review. Thanks. |
|
This still references to fog-core 1.4.5, is this intentionally? |
|
The issue is still present. Any thoughts on how to remedy this? |
wichru
pushed a commit
to starfish-codes/archived-fog-azure-rm-v2
that referenced
this pull request
Mar 21, 2023
Add Fog Support for Azure Stack
wichru
added a commit
to starfish-codes/archived-fog-azure-rm-v1
that referenced
this pull request
Mar 21, 2023
* Add Fog Support for Azure Stack (fog#386) Add Fog Support for Azure Stack * add fog debug var * improved syntax * add blob operation timeout make options array thread safe * fix code style * FIX build issues with some ruby versions * UPDATE add new ruby versions * FIX linting issue * Update azure-storage to 1.1, unpin fog-core/fog-json, fix tests Co-authored-by: Jenna Goldstrich <[email protected]> Co-authored-by: Seth Boyles <[email protected]> --------- Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Peter Sternberger <[email protected]> Co-authored-by: Wesley Beary <[email protected]> Co-authored-by: MSSedusch <[email protected]> Co-authored-by: HappyTobi <[email protected]> Co-authored-by: Jenna Goldstrich <[email protected]> Co-authored-by: Seth Boyles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.