Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CF] improve logging and error handling #434

Open
wants to merge 4 commits into
base: fog-arm-cf
Choose a base branch
from
Open

[CF] improve logging and error handling #434

wants to merge 4 commits into from

Conversation

MSSedusch
Copy link

Improvements:

  • add another rescue case to catch all errors and log them
  • add correlation id to logs to be able to map put_block, create_block and delete_block operations

houndci-bot
houndci-bot reviewed Nov 19, 2020
View reviewed changes
lib/fog/azurerm/requests/storage/put_blob_block.rb Outdated
raise_azure_exception(ex, msg)
rescue => e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

lib/fog/azurerm/requests/storage/put_blob_block.rb Outdated
@@ -6,26 +6,36 @@ class Real
def put_blob_block(container_name, blob_name, block_id, data, options = {})
my_options = options.clone
my_options[:request_id] = SecureRandom.uuid

correlation_id = SecureRandom.uuid
if my_options[:fog_correlation_id] != nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

lib/fog/azurerm/requests/storage/multipart_save_block_blob.rb Outdated
my_options = options.clone

correlation_id = SecureRandom.uuid
if my_options[:fog_correlation_id] != nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

lib/fog/azurerm/requests/storage/delete_blob.rb Outdated
raise_azure_exception(ex, msg)
rescue => e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

lib/fog/azurerm/requests/storage/delete_blob.rb Outdated
msg = "Deleting blob: #{blob_name} in container #{container_name}. options: #{my_options}"

correlation_id = SecureRandom.uuid
if my_options[:fog_correlation_id] != nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

lib/fog/azurerm/requests/storage/create_block_blob.rb Outdated
raise_azure_exception(ex, msg)
rescue => e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

lib/fog/azurerm/requests/storage/create_block_blob.rb Outdated
@@ -6,17 +6,23 @@ class Real
def create_block_blob(container_name, blob_name, body, options = {})
my_options = options.clone
my_options[:request_id] = SecureRandom.uuid

correlation_id = SecureRandom.uuid
if my_options[:fog_correlation_id] != nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb Outdated
raise_azure_exception(ex, msg)
rescue => e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/RescueStandardError: Avoid rescuing without specifying an error class.

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb Outdated
msg = "commit_blob_blocks: Complete uploading #{blob_name} to the container #{container_name}. options: #{my_options}"

correlation_id = SecureRandom.uuid
if my_options[:fog_correlation_id] != nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb Outdated
@@ -6,16 +6,26 @@ class Real
def commit_blob_blocks(container_name, blob_name, blocks, options = {})
my_options = options.clone
my_options[:request_id] = SecureRandom.uuid
msg = "commit_blob_blocks: Complete uploading #{blob_name} to the container #{container_name}. options: #{my_options}"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot
houndci-bot reviewed Nov 19, 2020
View reviewed changes
lib/fog/azurerm/requests/storage/put_blob_block.rb Outdated
@@ -6,26 +6,36 @@ class Real
def put_blob_block(container_name, blob_name, block_id, data, options = {})
my_options = options.clone
my_options[:request_id] = SecureRandom.uuid

correlation_id = SecureRandom.uuid
if !my_options[:fog_correlation_id].nil?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

lib/fog/azurerm/requests/storage/delete_blob.rb Outdated
msg = "Deleting blob: #{blob_name} in container #{container_name}. options: #{my_options}"

correlation_id = SecureRandom.uuid
if !my_options[:fog_correlation_id].nil?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

lib/fog/azurerm/requests/storage/create_block_blob.rb Outdated
@@ -6,17 +6,23 @@ class Real
def create_block_blob(container_name, blob_name, body, options = {})
my_options = options.clone
my_options[:request_id] = SecureRandom.uuid

correlation_id = SecureRandom.uuid
if !my_options[:fog_correlation_id].nil?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb Outdated
msg = "commit_blob_blocks: Complete uploading #{blob_name} to the container #{container_name}. options: #{my_options}"

correlation_id = SecureRandom.uuid
if !my_options[:fog_correlation_id].nil?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/NegatedIf: Favor unless over if for negative conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSSedusch @houndci-bot