Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolize keys so we don't break Paperclip on Ruby 2.6 #544

Closed
wants to merge 1 commit into from

Conversation

Temikus
Copy link
Member

@Temikus Temikus commented Jul 30, 2021

Fixes #535

Copy link
Member

@icco icco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of our tests are failing, but the code looks good.

@Temikus
Copy link
Member Author

Temikus commented Aug 8, 2021

Nah this is not working in 2.7, need to rewrite:

Minitest::UnexpectedError:         SyntaxError: /runner/_work/fog-google/fog-google/lib/fog/storage/google_json/requests/get_object.rb:39: syntax error, unexpected '.', expecting ')'
        ...                     **options.transform_keys(&:to_sym), &_b...

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This pr has been marked inactive and will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double-splat (**options) operator fails on hash with string keys in put_object() call
3 participants