Allow bumping fog-core #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Seth Boyles <[email protected]>
|
@sethboyles Thanks, I've kicked off the ci for us. This seems fine to me, but I would like @Temikus to have a chance to speak up, in case I'm missing something. |
|
@Temikus Thanks! |
|
Released in v1.18.0. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #422, in order to get newer versions of fog-core to enable compatibility with other fog provider gems.
Looking into the history, it looks like a similar change was reverted: #419 #487
There is talk of a regression, but all unit tests pass and as far as I can tell the only issue is the deprecation warnings.
It's been years since talk doing the update 'properly' and #422 seems to be stuck in limbo. At this point this gem lagging behind fog-core and other provider gems is no longer a minor inconvenience--it is blocking us from getting new features in other provider gems and from upgrading to Ruby 3.
We would much rather allow the deprecation warnings than continue to be stuck on a very old version (1.7, per this comment). That version is blocking us on upgrading other gems because some of its dependencies are locked to old versions that are incompatible with other gems.
After this is merged, we can tackled the deprecation warnings piecemeal, or we those who are annoyed by them can silence them (or pin to fog-core 2.1).
cc @Temikus @geemus
Authored-by: Seth Boyles [email protected]