googlefonts/font_names: raise warn for families with MORF axis #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a family contains a Morph axis, it most likely doesn't have a default stylename that conforms to our specification since our spec assumes every font will have a weight axis, or at least a Regular style. Imo it is impossible to determine what the stylename will be since the designer can choose anything so it's best we just skip the check. However, instead of skipping, I feel it's better to raise a warn and inform the user that the font contains a Morph axis and to provide an example font. (PR #4881)
felipesanches
force-pushed
the
morf-name
branch
from
21152cf
to
58de8d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a family contains a Morph axis, it most likely doesn't have a default stylename that conforms to our specification since our spec assumes every font will have a weight axis, or at least a Regular style.
Imo it is impossible to determine what the stylename will be since the designer can choose anything so it's best we just skip the check. However, instead of skipping, I feel it's better to raise a warn and inform the user that the font contains a Morph axis and to provide an example font.
Checklist
CHANGELOG.md