Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding added #509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Padding added #509

wants to merge 1 commit into from

Conversation

plxity
Copy link
Member

@plxity plxity commented Dec 21, 2018

Fixes #507

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Padding is added in the message displayed when clicked on mic button

Changes proposed in this pull request:

  • Padding added

ms10398
ms10398 requested changes Dec 22, 2018
View reviewed changes
Copy link
Member

@ms10398 ms10398 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis and Codacy is failing becuase of mixed quotes please fix that you can test locally by jshint once before pushing

@plxity
Copy link
Member Author

plxity commented Dec 22, 2018

@ms10398 Thank you for the help. I have done the changes. Please review.

@fossasia fossasia deleted a comment Dec 22, 2018
@fossasia fossasia deleted a comment from plxity Dec 22, 2018
@fossasia fossasia deleted a comment from ms10398 Dec 22, 2018
@plxity
Copy link
Member Author

plxity commented Dec 23, 2018

@ms10398 Please review this.

AdityaSrivast
AdityaSrivast reviewed Dec 27, 2018
View reviewed changes
Copy link
Member

@AdityaSrivast AdityaSrivast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plxity Please stash your commits

@plxity
padding
c5e2887 
changes

Update script.js
@plxity
Copy link
Member Author

plxity commented Jan 3, 2019 •
edited
Loading

@ms10398 @zamhaq Please review this.

fragm3
fragm3 requested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill the commit message, title, add screenshot(always if it's UI change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSrivast AdityaSrivast AdityaSrivast left review comments

@fragm3 fragm3 fragm3 requested changes

@ms10398 ms10398 ms10398 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No padding present
4 participants
@plxity @fragm3 @ms10398 @AdityaSrivast