Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signup: new UI for signup page #524

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

signup: new UI for signup page #524

wants to merge 2 commits into from

Conversation

ambujraj
Copy link
Member

@ambujraj ambujraj commented Jan 12, 2019 •
edited
Loading

Fixes #521

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

The signup UI should look more attractive.

Changes proposed in this pull request:

  • Changes the UI design for better look and more attractive.

Screenshot of the change

d

samagragupta
samagragupta reviewed Jan 13, 2019
View reviewed changes
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide padding between email and password text field.

@ambujraj
Copy link
Member Author

@samagragupta done.

samagragupta
samagragupta approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just squash the commits.

@ambujraj
Copy link
Member Author

ambujraj commented Jan 15, 2019 •
edited
Loading

done @samagragupta

@ambujraj
Copy link
Member Author

@samagragupta can you please reply if any changes is required

fragm3
fragm3 requested changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@fragm3 fragm3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove bootstrap.min.js changes, avoid adding extra new lines

@ambujraj
Copy link
Member Author

@fragm3 I didn't get you. Can you please elaborate

@fragm3
Copy link
Contributor

fragm3 commented Feb 4, 2019

@ambujraj bootstrap.min.css changes are not needed remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fragm3 fragm3 fragm3 requested changes

@neeraj3029 neeraj3029 neeraj3029 approved these changes

@samagragupta samagragupta samagragupta approved these changes

@yashasvi128 yashasvi128 yashasvi128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signup UI design need to improve
5 participants
@ambujraj @fragm3 @neeraj3029 @samagragupta @yashasvi128