New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollIconTopElement is shown when message window is at bottom #543

Open

samagragupta wants to merge 1 commit into fossasia:master from samagragupta:signeye

Member

samagragupta commented Jun 8, 2019

Fixes #542

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream master branch.
The unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

When a user is at the bottom of the message window then scrollIconTopElement should shown.

Changes proposed in this pull request:


          scrollIconTopElement is shown when message window is at bottom

cce2b75

Dishebh approved these changes

View reviewed changes

Member Author

samagragupta commented Feb 9, 2020

@mariobehling Please review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet