Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(chisel): replace solang with solar in SolidityHelper #9376

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore(chisel): replace solang with solar in SolidityHelper #9376

merged 1 commit into from
Nov 22, 2024
+117 −154

Conversation

DaniPopes
Copy link
Member

Ref #9317

grandizzy
grandizzy approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I did some manual checks for common functionality, just in case since we don't have unit tests for chisel :(

@DaniPopes DaniPopes merged commit 1332b6d into master Nov 22, 2024
22 checks passed
@DaniPopes DaniPopes deleted the dani/chisel-helper-solar branch November 22, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grandizzy grandizzy grandizzy approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @grandizzy