Update emscripten for Node 18 support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhurliman
approved these changes
Nov 29, 2022
| node-version: | ||
| - 14.x | ||
| - 16.x | ||
| - 18.x |
There was a problem hiding this comment.
Might as well test 20.x so we catch the next problem :)
defunctzombie
approved these changes
Nov 29, 2022
| @@ -46,5 +46,8 @@ | |||
| "jest-ts-webcompat-resolver": "1.0.0", | |||
| "prettier": "2.3.2", | |||
| "typescript": "4.3.5" | |||
| }, | |||
| "dependencies": { | |||
| "tslib": "^2" | |||
There was a problem hiding this comment.
What makes this project depend on tslib? I've constantly found myself struggling to understand when I need to add tslib as a dependency vs when I don't/
There was a problem hiding this comment.
There was a problem hiding this comment.
You must depend on tslib when importHelpers is set to true. Ideally, it is set to true in all TypeScript libraries your project depends on so TS standard library functions are compiled into your app once instead of repeated in the compiled source of each package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Upgrade emscripten to fix compatibility with Node 18.
Description
Fixes #4