Add option to build as an ament package #817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually this maybe isn't good. I see there are an examples package which I could make an ament packages as well, but it depends on foxglove protobuf schema stuff which i'm not really wanting to ament-ize all of that. Also it seems the foxglove_rosbridge package has a parallel implementation of the websocket protocol and seems to be more up to date? 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Add a
package.xmland update theCMakeLists.txtto optionally allow users to build as an ament package.Docs
None
Description
I added a
package.xmland some updates to theCMakeLists.txtso this package could be used in ros2 workspaces. Note that this should only have an affect if it is already in a ros2 workspace and theament_cmakepackage is found. If not then it should continue to compile as before.Help Needed
I wasn't sure what to put for some of the fields in the
package.xml, so if this is acceptable feel free to edit and modify maintainer info or you can tell me what it should be and i'll add it. Thanks!