feat(perseus-cli): add 'node_modules' to watch exclusions #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, this will definitely streamline things significantly for a lot of people! Thanks, and sorry for the late reply! |
|
There seem to be some issues in |
|
All fixed on |
Signed-off-by: Etienne <[email protected]>
gladion136
force-pushed
the
feat/309-watch-ignore-large-folders
branch
from
fd4aad0
to
dba928c
Compare
|
Sorry for the late reply! The branch is now rebased to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Like described inside this issue: 309
perseus serve -wis very slow when listening to a large number of files.This change
This PR will not fix this in every case but it adds the
node_modulesfolder to the watch exclusions. The 'node_modules' folder is similar to thetargetfolder but from npm and it's often huge. I think a lot of developer has anode_modulesfolder because they are using bootstrap, tailwind or some other npm dependencies inside there perseus projects.