-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handbook/wine: add Mizuma's source code URL, and small typos #360
Conversation
rilysh
commented
Mar 25, 2024
- It's particularly interesting to know what games/apps are currently "supported" through Mizuma, so it's a good idea to link the source code URL (winetricks source code URL is also already mentioned.)
- Remove the word "some" from the synopsis. It's ambiguous to know the meaning of "some" here, whereas Wine is intended (and does support) a wide range of Windows applications out of the box.
- Use the word GitHub instead Github (ignorable).
- Also edit the Arch Wiki URL (it redirects to that new URL from the previous one) (forgot to mention in the commit).
1. It's particularly interesting to know what games/apps are currently "supported" through Mizuma, so it's a good idea to link the source code URL (winetricks source code URL is also already mentioned.) 2. Remove the word "some" from the synopsis. It's ambiguous to know the meaning of "some" here, whereas Wine is intended (and does support) a wide range of Windows applications out of the box. 3. Use the word GitHub instead Github (ignorable). Signed-off-by: rilysh <[email protected]>
Thanks for the changes. I'll make the commit this night. |
Friendly reminder, ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is committed to main now, as 224f316.
So we should close the PR.
@@ -52,7 +52,7 @@ endif::[] | |||
== Synopsis | |||
|
|||
https://www.winehq.org/[WINE], which stands for Wine Is Not an Emulator, is technically a software translation layer. | |||
It enables to install and run some software written for Windows(R) on FreeBSD (and other) systems. | |||
It enables to install and run software written for Windows(R) on FreeBSD (and other) systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this with a follow-up commit since it was a preexisting issue unaffected by your edit, but "enables" is a transitive verb that needs a direct object, like "it enable users to install and run software" ... but "users" is pretty vague in this context so I went with an alternative verb that is intransitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
@@ -556,7 +556,7 @@ image::winetricks-uninstall-3.png[] | |||
[[homura]] | |||
=== Mizutamari | |||
|
|||
Mizutamari is an application similar to `winetricks`, although it was inspired by the https://lutris.net/[Lutris] gaming system for Linux. | |||
https://codeberg.org/Alexander88207/Mizutamari[Mizutamari] is an application similar to `winetricks`, although it was inspired by the https://lutris.net/[Lutris] gaming system for Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also available in the ports collection as games/mizuma, but the link to its homepage seems more appropriate than the ports collection entry, for this purpose, so I left it alone.
1. It's particularly interesting to know what games/apps are currently "supported" through Mizuma, so it's a good idea to link the source code URL (winetricks source code URL is also already mentioned.) 2. Remove the word "some" from the synopsis. It's ambiguous to know the meaning of "some" here, whereas Wine is intended (and does support) a wide range of Windows applications out of the box. 3. Use the word GitHub instead Github (ignorable). Signed-off-by: rilysh <[email protected]> Pull Request: <#360
This is committed. |
1. It's particularly interesting to know what games/apps are currently "supported" through Mizuma, so it's a good idea to link the source code URL (winetricks source code URL is also already mentioned.) 2. Remove the word "some" from the synopsis. It's ambiguous to know the meaning of "some" here, whereas Wine is intended (and does support) a wide range of Windows applications out of the box. 3. Use the word GitHub instead Github (ignorable). Signed-off-by: rilysh <[email protected]> Pull Request: <freebsd#360