private-wifi: rename ifname to wan_wifiX to not collide with openwrt devices with more than one wan port #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
3. topic: package
maurerle
changed the title
blocktrron
reviewed
Jun 27, 2024
| ifname = suffix and 'wan' .. suffix, | ||
| ifname = suffix and 'wan_wifi' .. suffix, |
There was a problem hiding this comment.
Even though the package is called "private-wifi", we agreed some time ago to only continue using the term "WLAN", as "WiFi" is associated with the WiFi Alliance.
There was a problem hiding this comment.
How about making it a "wl" prefix, naming the interface "wlwanX"? Could also be used like "wlclient", "wlmesh", ... in the future as a common naming scheme.
There was a problem hiding this comment.
Sounds good, what about wl_wanX and wl_client/wl_mesh in the future?
There was a problem hiding this comment.
If we add a separator (which I do not have strong opinions on), I'd rather use wl- to match OpenWrt's br-.
…vices with more than one wan port closes freifunk-gluon#3290
maurerle
force-pushed
the
private_wifi_ifname
branch
from
56acc5e
to
2b61b02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no device is affected, though it makes sense to improve the current situation by giving more meaningful ifnames anyway.
closes #3290