Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge cases in steps.field_update when primaryKey and foreignKeys are renamed #1598

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix edge cases in steps.field_update when primaryKey and foreignKeys are renamed #1598

wants to merge 7 commits into from

Commits on Oct 5, 2023

  1. add failing test for update of field name in non-primary key field wh… 

    …en primary keys exists
    @fjuniorr
    fjuniorr committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6c7291a View commit details
    Browse the repository at this point in the history

  2. Fix x not in list error 

    if self.name is not part of the primary key, it can't be dropped from the pk
    @fjuniorr
    fjuniorr committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4616a7f View commit details
    Browse the repository at this point in the history

  3. add failing test for update of field name of foreign key

    @fjuniorr
    fjuniorr committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6f5f9e4 View commit details
    Browse the repository at this point in the history

  4. Update foreignKeys regardless of primaryKey

    @fjuniorr
    fjuniorr committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    268ee63 View commit details
    Browse the repository at this point in the history

  5. run make format

    @fjuniorr
    fjuniorr committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1d69793 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. add failing test when foreign key and referenced column have same name

    @fjuniorr
    fjuniorr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0e98f66 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Merge branch 'main' into 1560/fix-field-update

    @roll
    roll authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6e82f5f View commit details
    Browse the repository at this point in the history