Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: indexer option to skip constraints creation #1691

Merged
merged 3 commits into from
Sep 28, 2024
Merged

feat: indexer option to skip constraints creation #1691

merged 3 commits into from
Sep 28, 2024

Conversation

roll
Copy link
Member

@roll roll commented Sep 26, 2024

  • Open Data Editor needs a way to create flexible database tables that can have some constraint violations for further fixing. So here is a new Indexer.without_constraints flag to achieve this goal.

@pierrecamilleri
can you please take a look?

pierrecamilleri
pierrecamilleri approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@pierrecamilleri pierrecamilleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

frictionless/formats/sql/adapter.py Outdated Show resolved Hide resolved
frictionless/formats/sql/mapper.py Outdated Show resolved Hide resolved
@roll
Copy link
Member Author

roll commented Sep 28, 2024

Thanks!

@roll roll merged commit 7cadf17 into main Sep 28, 2024
9 checks passed
@roll roll deleted the indexer-option-to-skip-constraints-creation branch September 28, 2024 08:39
@roll roll mentioned this pull request Sep 28, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrecamilleri pierrecamilleri pierrecamilleri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roll @pierrecamilleri