Skip to content

Commit

Permalink
fix Windows build by properly generating release library
Browse files Browse the repository at this point in the history
  • Loading branch information
fuzzybinary committed Sep 2, 2024
1 parent 04d01c0 commit ae5161e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
include:
- os: windows-latest
artifact-name: windows-x64
artifact-path: godot_dart.dll
artifact-path: Release/godot_dart.dll
- os: ubuntu-latest
artifact-name: linux-x64
artifact-path: libgodot_dart.so
Expand All @@ -30,14 +30,14 @@ jobs:
working-directory: ./tools/binding_generator
- name: Build Shared Library
run: |
cmake . -B './build'
cmake -DCMAKE_BUILD_TYPE=Release . -B "build"
cmake --build build --config release
working-directory: ./src/cpp
- name: 'Upload Artifact'
uses: actions/upload-artifact@v3
with:
name: ${{ matrix.artifact-name }}
path: ./src/cpp/build/Release/${{ matrix.artifact-path }}
path: ./src/cpp/build/${{ matrix.artifact-path }}

assemble:
runs-on: ubuntu-latest
Expand All @@ -54,7 +54,7 @@ jobs:
cp -r src/assets/* out/extension
cp src/dart_dll/bin/release/dart_dll_win64.dll out/extension
cp src/dart_dll/bin/release/libdart_dll.so out/extension
cp src/dart_dll/bin/release/libdart_dll_mac.dylib out/extension
cp src/dart_dll/bin/release/libdart_dll.dylib out/extension
cp artifacts/windows-x64/godot_dart.dll out/extension
cp artifacts/linux-x64/libgodot_dart.so out/extension
cp artifacts/macos/libgodot_dart.dylib out/extension
Expand Down
1 change: 0 additions & 1 deletion src/cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ set(EXAMPLE_DIR "${PROJECT_SOURCE_DIR}/../../example")

set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED True)
set(CMAKE_BUILD_TYPE Debug)

set(FLOAT_PRECISION "single")
add_subdirectory(${GODOT_CPP_DIR} "godot-cpp")
Expand Down

0 comments on commit ae5161e

Please sign in to comment.