Support CTRL + Backspace for deleting word in Entry #4084
Conversation
Jacalz
changed the title
widget/entry.go
Outdated
| e.shortcut.AddShortcut(&desktop.CustomShortcut{KeyName: fyne.KeyLeft, Modifier: fyne.KeyModifierShortcutDefault}, unselectMoveWord) | ||
| e.shortcut.AddShortcut(&desktop.CustomShortcut{KeyName: fyne.KeyLeft, Modifier: fyne.KeyModifierShortcutDefault | fyne.KeyModifierShift}, selectMoveWord) | ||
| e.shortcut.AddShortcut(&desktop.CustomShortcut{KeyName: fyne.KeyRight, Modifier: fyne.KeyModifierShortcutDefault}, unselectMoveWord) | ||
| e.shortcut.AddShortcut(&desktop.CustomShortcut{KeyName: fyne.KeyRight, Modifier: fyne.KeyModifierShortcutDefault | fyne.KeyModifierShift}, selectMoveWord) | ||
| e.shortcut.AddShortcut(&desktop.CustomShortcut{KeyName: fyne.KeyBackspace, Modifier: fyne.KeyModifierShortcutDefault}, removeWord) |
There was a problem hiding this comment.
On Mac the shortcut for this is Option (alt) + backspace. I think we should try to follow this convention, either using different files with build guards to define the shortcuts, or runtime.GOOS checks
There was a problem hiding this comment.
Hmm, interesting. I updated it to use the alt shortcut on macOS instead.
There was a problem hiding this comment.
Interesting find: It seems like Go is smart enough to optimize away runtime.GOOS checks. It is a trivial optimization but nevertheless, I am impressed :)
https://go.godbolt.org/z/b8GYaxz6Y
|
Thanks but it is still draft because there seems to be a few bugs that I need to sort out :/ |
|
I wonder if we could address #2462 in this PR (or a follow up) as well :) |
|
Do we not already support that? |
|
No we don't, not yet. On Mac it's the same with Alt instead of Ctrl/Cmd being the modifier. |
|
I suppose that issue should be closed and there should be a specific one for macOS using Alt key instead in that case. The idea of the original issue seems to be fixed (ctrl is supported). It doesn't necessarily seem like something that has to be part of this PR. You're more than welcome to follow up with a PR yourself. I only have very infrequent access to my macOS computer so can't verify the change ;) |
Oh, my bad - the Ctrl+left/right was added on develop and I didn't realize it since it wasn't present in my app building against 2.3.x. All that would be needed to match MacOS conventions would be to use your |
|
What I am trying to say is that this is quite broken at the moment and it will be a while until I get it fixed up. You might want to open a PR if you want it on v2.4.0. |
|
I haven't had time to fix up the issues here. Closing for now and opening #4524 in case anyone wants to pick it up. |
Description:
This adds support for pressing
ctrl + backspacefor deleting a whole word.Opening as draft until I have added support for
ctrl + deletefor deleting a whole word to the left as well.Checklist: