-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sugest to avoid to memory leak #4118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the way that some callbacks are deleted and others moved.
Why not make the PR just about the memory leak fix?
this lines: https://github.com/fyne-io/fyne/pull/4118/files#diff-86b6487000ebad8b8c46272d0aa615cdbec1dba15013d82bed007ffa593e5464R90 is memory leaks, others are only therefore nothing theese functions do and call GO from C is recomended to eliminate ... |
But you have, as stated in #4118 (comment), removed one of the functions. Why? |
I think I see why it looks inconsistent - because the |
ok |
Why did you close it? Andy just suggested changes |
ach soory, I will changes tomorow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these optimisations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. If there are more places where we are passing Go functions back into C, we probably want to remove those as well some time in the future. It is quite slow from what I have understood (but a lot faster in Go 1.21).
well there are some functions like |
avoid memory leak resume and sugest to avoid to call GO functions for empty life cycle functions ...