Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor redesign of tabs to use rounded corners #4135

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Aug 4, 2023

Description:

This implements my suggestion about adding rounded hover selection and also rounds off the indicator. I am very happy with the look of this.

Video demo in Rymdport:

Screencast.from.2023-08-04.22-22-34.webm

Images:

image
Screenshot from 2023-08-04 22-40-02

Fixes #4130

Checklist:

  • Tests included. <- Covered by existing tests
  • Lint and formatter run with no errors.
  • Tests all pass.

@Jacalz Jacalz changed the title 4160 rounded tabs Minor redesign of tabs to use rounded corners Aug 4, 2023
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for figuring a nice solution

@coveralls
Copy link

Coverage Status

coverage: 65.123% (+0.002%) from 65.121% when pulling b6bd139 on Jacalz:4160-rounded-tabs into dbe853f on fyne-io:develop.

@Jacalz Jacalz merged commit 4e8dee1 into fyne-io:develop Aug 5, 2023
11 checks passed
@Jacalz Jacalz deleted the 4160-rounded-tabs branch August 5, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants