-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: granular plugin setting #3319
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit 56551e1.
… finish all integrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments:
-
After I activated this PR, all the Stackable blocks disappeared from my editor (steps: activate the PR, open the editor)
-
Adjusting settings should show a "Unsaved changes" near the save button. We can also make the button grayed out if no changes have been made yet (but still clickable)
-
If you search for random characters (e.g. "kwjdnqwkhdnq") you'll see all the headings remaining
-
Remove all emojis from the headings since some have emojis and some don't
-
Looks like a lot of the settings have line separators between them. Lines should only appear between different sections of settings. Only the red lines here should have lines:
…ree for single check (remaining heading fix)
@bfintal The latest commits are for migrating from |
@andeng1106 For the QA, we need to verify the following:
|
fixes #3354