Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: granular plugin setting #3319

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from
Open

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Sep 23, 2024

fixes #3354

@Arukuen Arukuen self-assigned this Oct 7, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments:

  1. After I activated this PR, all the Stackable blocks disappeared from my editor (steps: activate the PR, open the editor)

  2. Adjusting settings should show a "Unsaved changes" near the save button. We can also make the button grayed out if no changes have been made yet (but still clickable)

  3. If you search for random characters (e.g. "kwjdnqwkhdnq") you'll see all the headings remaining

  4. Remove all emojis from the headings since some have emojis and some don't

  5. Looks like a lot of the settings have line separators between them. Lines should only appear between different sections of settings. Only the red lines here should have lines:

Screenshot 2024-11-06 at 9 41 41 AM

@Arukuen
Copy link
Contributor Author

Arukuen commented Nov 19, 2024

@bfintal The latest commits are for migrating from disabled_blocks array to block_states object to fix disappearing blocks. Since the previous definition of disabled is hidden, when migrating, should the previous disabled blocks be hidden in the new implementation?

@bfintal
Copy link
Contributor

bfintal commented Nov 20, 2024

@andeng1106 For the QA, we need to verify the following:

  1. A clean install of this build in a new site (never installed Stackable before), all the blocks are present
  2. When updating to this build, if you haven't touched the settings before (you installed an older version of Stackable previously but didn't touch the settings), all the blocks should be present
  3. When updating to this build, and you have previously saved the settings before (a non-block setting, for example disabling the design library button), after updating to this build, all the blocks should be present
  4. When updating to this build, and you have previously saved the settings before (you disabled 1 block in the settings), after updating to this build, all blocks should be present except for the 1 disabled block (it should now show as "hidden")
  5. The number 4 above should also work if multiple blocks were previously disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Granular Plugin Settings
2 participants