Ensure resource cleanup and add integration test for invalid credentials #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
area/usability
|
@EmoinLanyu Thank you for your contribution. |
|
@EmoinLanyu You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
needs/rebase
|
/test |
|
Testrun: e2e-wqmgf +---------------------+---------------------+--------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+--------+----------+ | infrastructure-test | infrastructure-test | Failed | 3m59s | +---------------------+---------------------+--------+----------+ |
EmoinLanyu
force-pushed
the
fix_infra_test
branch
from
332f7f5
to
dc57060
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-vbx4p +---------------------+---------------------+--------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+--------+----------+ | infrastructure-test | infrastructure-test | Failed | 11m45s | +---------------------+---------------------+--------+----------+ |
|
/test |
|
Testrun: e2e-v7d7j +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 11m37s | +---------------------+---------------------+-----------+----------+ |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
please run |
|
/squash |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
jia-jerry
reviewed
Mar 3, 2022
jia-jerry
reviewed
Mar 3, 2022
shaoyongfeng
reviewed
Mar 3, 2022
|
/test |
|
Testrun: e2e-tjcsh +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 11m55s | +---------------------+---------------------+-----------+----------+ |
gardener-robot-ci-1
added
reviewed/ok-to-test
shaoyongfeng
reviewed
Mar 7, 2022
| @@ -127,17 +131,15 @@ var _ = AfterSuite(func() { | |||
| mgrCancel() | |||
| }() | |||
|
|
|||
| By("running cleanup actions") | |||
| framework.RunCleanupActions() | |||
There was a problem hiding this comment.
Does it mean all namespaces generated during testing are only be cleaned at the end of testing? Is it expected behavior?
| @@ -535,6 +624,7 @@ func prepareVPC(ctx context.Context, clientFactory alicloudclient.ClientFactory, | |||
| vpcClient, err := clientFactory.NewVPCClient(region, *accessKeyID, *accessKeySecret) | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| createVpcReq := vpc.CreateCreateVpcRequest() | |||
| createVpcReq.VpcName = "provider-alicloud-infra-test" | |||
There was a problem hiding this comment.
what will happen if there are several testing running in parallel? will this name cause any conflict?
No it won't. VPC name is not required to be unique. So there is no problem here. |
Yes the clean up actions are carried out at the end of the testing. The clean up actions will still be done should any tests fail. |
shaoyongfeng
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind test
/platform alicloud
What this PR does / why we need it:
This PR tests gardener/terraformer#93 and gardener/gardener#3950 by adding an integration test case for invalid credentials.
It creates an infrastructure resource but uses invalid credentials and ensures that the ERR_INFRA_UNAUTHENTICATED is correctly detected from the termination message and that the infrastructure can still be deleted afterwards (as it's a no-op).
Before this PR, the destroy logic and testing was executed as part of a cleanup action, while the destroy logic should be part of the actual test and not just cleanup. Also, this could lead to resource leakage on AliCloud and on the test-machinery cluster, because if one cleanup action fails (e.g. the destroy logic) no further cleanup actions are executed.
Now, the destroy logic is executed as a deferred function to ensure that the cleanup actions are still run, even if the test itself fails.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Ref:
Release note: