Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce persona-based docs #632

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Introduce persona-based docs #632

merged 1 commit into from
Jul 14, 2023

Conversation

vlerenc
Copy link
Member

@vlerenc vlerenc commented Jul 8, 2023

What this PR does / why we need it:
We would like to introduce persona-based docs focussing on the already known release notes personas and therefore "cleanup" the structure somewhat:

  • users (/docs/usage)
  • operators (/docs/operations)
  • developers (/docs/development)

Special notes for your reviewer:
cc @n-boshnakov

Release note:
None as ~30 PRs have/will be opened and the message would be the same everywhere (no relevant content changes either) while the only thing that actually changes in the end is the docs page that will have its release note.

/kind/cleanup

@vlerenc vlerenc requested review from a team as code owners July 8, 2023 15:10
@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up needs/rebase Needs git rebase labels Jul 8, 2023
@gardener-robot
Copy link

@vlerenc You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 8, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2023
@vlerenc
Copy link
Member Author

vlerenc commented Jul 14, 2023

Could someone PTAL/merge?

@shaoyongfeng
Copy link
Contributor

HI @vlerenc can you solve the conflict?

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 14, 2023
@vlerenc
Copy link
Member Author

vlerenc commented Jul 14, 2023

@shaoyongfeng There was no issue, but sure, I now rebased my change onto master (no conflict). If you make this a condition, can you then please merge it timely?

@shaoyongfeng shaoyongfeng merged commit 2591983 into master Jul 14, 2023
4 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 14, 2023
@vlerenc
Copy link
Member Author

vlerenc commented Jul 14, 2023

Thanks @shaoyongfeng! :-)

@vlerenc vlerenc deleted the personadocs branch July 14, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants