Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admission] Add priorityClassName #732

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[admission] Add priorityClassName #732

merged 1 commit into from
Jul 19, 2024

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jul 8, 2024

How to categorize this PR?

/area robustness
/kind enhancement
/platform alicloud

What this PR does / why we need it:
This PR enhances the admission chart by the option to set a priorityClassName.

Which issue(s) this PR fixes:
Part of gardener/gardener#9936.

Release note:

A `priorityClassName` can now be set for the admission deployment via the `gardener-extension-admission-alicloud` Helm chart.

@timuthy timuthy requested review from a team as code owners July 8, 2024 07:44
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2024
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2024
oliver-goetz
oliver-goetz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2024
@oliver-goetz oliver-goetz merged commit dd2f8e0 into gardener:master Jul 19, 2024
18 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 19, 2024
@timuthy timuthy deleted the enh/admission-prio-class branch July 19, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-goetz oliver-goetz oliver-goetz approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/alicloud Alicloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timuthy @oliver-goetz @gardener-robot-ci-1 @gardener-robot