Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce InfrastructureConfigFromCluster and use it instead of API call #1068

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Introduce InfrastructureConfigFromCluster and use it instead of API call #1068

merged 2 commits into from
Oct 15, 2024

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Sep 24, 2024 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area quality
/kind bug
/platform aws

What this PR does / why we need it:
This PR introduces InfrastructureConfigFromCluster that extracts the infrastructureConfig from a cluster resource and uses it in pkg/webhook/controlplane/ensurer.go instead of an API call.

Which issue(s) this PR fixes:
This fixes a issue where cluster force deletion may fail

Special notes for your reviewer:

Release note:

An issue causing Shoot force deletion to fail because the control plane webhook failing to get the Infrastructure object from the Seed cluster is now fixed. The control plane webhook now reads the infrastructureConfig from the Shoot spec in the Cluster resource. Previously, it was fetching the Infrastructure object from the Seed cluster and was reading the infrastructureConfig from there.

@Kostov6 Kostov6 requested review from a team as code owners September 24, 2024 08:25
@gardener-robot gardener-robot added needs/review Needs review kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure labels Sep 24, 2024
@gardener-robot
Copy link

@Kostov6 Label area/bug does not exist.

@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Sep 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 24, 2024
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Sep 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 24, 2024
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug labels Sep 24, 2024
@Kostov6 Kostov6 changed the title Introduce InfrastructureConfigFromCluster and use it instead of api call Introduce InfrastructureFromCluster and use it instead of api call Sep 24, 2024
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 27, 2024
@ialidzhikov ialidzhikov changed the title Introduce InfrastructureFromCluster and use it instead of api call Introduce InfrastructureConfigFromCluster and use it instead of api call Sep 27, 2024
@ialidzhikov ialidzhikov changed the title Introduce InfrastructureConfigFromCluster and use it instead of api call Introduce InfrastructureConfigFromCluster and use it instead of API call Sep 27, 2024
ialidzhikov
ialidzhikov previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 27, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 27, 2024
@hebelsan
Copy link
Contributor

hebelsan commented Oct 9, 2024

/lgtm

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 15, 2024
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Oct 15, 2024
@gardener-robot
Copy link

@Kostov6 You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Oct 15, 2024
@gardener-robot gardener-robot added needs/changes Needs (more) changes needs/review Needs review labels Oct 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2024
@kon-angelo kon-angelo added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2024
kon-angelo
kon-angelo approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/rebase Needs git rebase needs/review Needs review labels Oct 15, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 15, 2024
@kon-angelo kon-angelo merged commit b77fda3 into gardener:master Oct 15, 2024
14 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 15, 2024
@hebelsan hebelsan mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@ialidzhikov ialidzhikov ialidzhikov left review comments

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Kostov6 @gardener-robot @hebelsan @ialidzhikov @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3