Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to deploy aws ipam controller #984

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented Jun 21, 2024

How to categorize this PR?

/area networking
/kind enhancement
/platform aws

What this PR does / why we need it:
The aws-ipam-controller is required to support prefix delegation for IPv6 and dual-stack mode. With this pull request the aws-ipam-controller can be enabled in the gardener-extension-provider-aws-configmap as feature gate. Once it is enabled it disables theallocate-node-cidrs field in the cloud-controller-manager and the kube-controller-manager for IPv6 or dual-stack shoot clusters.

apiVersion: v1
kind: ConfigMap
data:
  config.yaml: |
    ---
    apiVersion: aws.provider.extensions.config.gardener.cloud/v1alpha1
    kind: ControllerConfiguration
    ...
    featureGates:
      EnableIPAMController: true

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The aws-ipam-controller can now be enabled  in the `gardener-extension-provider-aws-configmap` as feature gate. It replaces the IPAM of the cloud-controller-manager and kube-controller-manager and supports additionally prefix delegation in case of IPv6 or dual-stack. 

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Jun 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 21, 2024
@kon-angelo
Copy link
Contributor

/assign

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2024
@kon-angelo
Copy link
Contributor

@DockToFuture do you think that this should be exposed on a shoot level ? Would it make sense as a seed featuregate instead ? I don't see value in the user manually fiddling with the IPAM - rather it is something that we know from the IP family support and we can configure it ourselves.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jul 11, 2024
@gardener-robot
Copy link

@DockToFuture You need rebase this pull request with latest master branch. Please check.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2024
AndreasBurger
AndreasBurger previously approved these changes Oct 14, 2024
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 14, 2024
@DockToFuture
Copy link
Member Author

Can we get this change in?

@kon-angelo
Copy link
Contributor

/test

@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Oct 16, 2024
@testmachinery
Copy link

testmachinery bot commented Oct 16, 2024

Testrun: e2e-g5qxr
Workflow: e2e-g5qxr-wf
Phase: Succeeded

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-tf      | Succeeded | 35m30s   |
| infrastructure-test | infrastructure-test-flow    | Succeeded | 26m7s    |
| infrastructure-test | infrastructure-test-migrate | Succeeded | 30m47s   |
| infrastructure-test | infrastructure-test-recover | Succeeded | 27m38s   |
| bastion-test        | bastion-test                | Succeeded | 8m29s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m10s    |
+---------------------+-----------------------------+-----------+----------+

@gardener-robot gardener-robot removed the needs/review Needs review label Oct 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 16, 2024
@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Oct 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 16, 2024
@kon-angelo kon-angelo self-requested a review October 16, 2024 17:19
@gardener-robot gardener-robot added needs/review Needs review and removed needs/changes Needs (more) changes labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/aws Amazon web services platform/infrastructure size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants