-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to deploy aws ipam controller #984
base: master
Are you sure you want to change the base?
Add option to deploy aws ipam controller #984
Conversation
/assign |
5358941
to
35d7ec3
Compare
35d7ec3
to
c85dba5
Compare
@DockToFuture do you think that this should be exposed on a shoot level ? Would it make sense as a seed featuregate instead ? I don't see value in the user manually fiddling with the IPAM - rather it is something that we know from the IP family support and we can configure it ourselves. |
@DockToFuture You need rebase this pull request with latest master branch. Please check. |
db4851d
to
6444cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can we get this change in? |
185c1c2
to
309eac8
Compare
/test |
Testrun: e2e-g5qxr +---------------------+-----------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+-----------------------------+-----------+----------+ | infrastructure-test | infrastructure-test-tf | Succeeded | 35m30s | | infrastructure-test | infrastructure-test-flow | Succeeded | 26m7s | | infrastructure-test | infrastructure-test-migrate | Succeeded | 30m47s | | infrastructure-test | infrastructure-test-recover | Succeeded | 27m38s | | bastion-test | bastion-test | Succeeded | 8m29s | | dnsrecord-test | dnsrecord-test | Succeeded | 6m10s | +---------------------+-----------------------------+-----------+----------+ |
How to categorize this PR?
/area networking
/kind enhancement
/platform aws
What this PR does / why we need it:
The aws-ipam-controller is required to support prefix delegation for IPv6 and dual-stack mode. With this pull request the aws-ipam-controller can be enabled in the
gardener-extension-provider-aws-configmap
as feature gate. Once it is enabled it disables theallocate-node-cidrs
field in the cloud-controller-manager and the kube-controller-manager for IPv6 or dual-stack shoot clusters.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: