Update lrauv_control_demo.sdf #2558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes warning of deprecated setting. Signed-off-by: Alessandro Sofia <[email protected]>
arjo129
requested changes
Aug 31, 2024
There was a problem hiding this comment.
Just disabling added mass is not sufficient. We need to add it to the links in the model themselves (See #2575). If you'd like to you can download the model from fuel and update it. Also I think we should change the typos in the error message in hydrodynamics and make it explicit that you should set the added mass parameters on the links themselves.
http://sdformat.org/spec?ver=1.11&elem=link#inertial_fluid_added_mass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Related to #1646
Summary
To reproduce the error run the simulation in gazebo ionic.
Output:
By adding the suggested tag the warning is removed.