Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve load times by skipping serialization of entities when unecessary. #2596

Open
wants to merge 4 commits into
base: gz-sim9
Choose a base branch
from

Commits on Sep 5, 2024

  1. A hack to greatly improve load times

    I was investigating
    gazebosim/gazebo_test_cases#1576 , in my
    investigation it came to my notice that `sdf::Element` takes forever to
    destroy (We should open a ticket somewhere about this). If we are
    skipping serialization we might as well not create and destroy an
    SDF Element. This hack greatly speeds up the load time for gazebo.
    
    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3b1ca48 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Remove magic word

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    da543ab View commit details
    Browse the repository at this point in the history
  2. Send empty string instead of using sentinel value.

    Signed-off-by: Arjo Chakravarty <[email protected]>
    arjo129 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    beadb78 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    4a833ac View commit details
    Browse the repository at this point in the history