-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out server constructor #2638
base: gz-sim8
Are you sure you want to change the base?
Conversation
Have these |
Was that reset error brought up in the last gazebo weekly meeting? This rings a bell:
|
Possibly, it rings a bell, that was over 24 hours ago, so it has been erased. |
Ran CI again, and the test failure went away. Looks like a flaky test. |
The windows failure is strange. The last build on the
|
Yeah, I was looking at those. I'm not yet sure what the problem is, but I'm looking into it. |
🎉 New feature
Summary
Moves a section of the
Server
constructor code to a separate function. The primary reason is to make the eventual download models in parallel PR easier to review. There is a side benefit of breaking up a large function into two smaller functions.I also replaced the static
DefaultWorld
with a default constructedsdf::World
object. This removes astatic
object, and will make sure the default world uses the latest sdf version.Commits:
DefaultWorld
with a default constructedsdf::World
object. 21ccdf0Test it
Tests should pass, and everything should work as normal.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.