Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.xml #125

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Add package.xml #125

merged 2 commits into from
Apr 17, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 23, 2024

🎉 New feature

Summary

Add package.xml based on dependencies found in .github/ci/packages.

This is to test out using vendor packages to provide Gazebo packages to ROS users (see gazebo-tooling/release-tools#1117).

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.98%. Comparing base (f928192) to head (cfc237c).

❗ Current head cfc237c differs from pull request most recent head 2d33fac. Consider uploading reports for the commit 2d33fac to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-utils2     #125   +/-   ##
==========================================
  Coverage      80.98%   80.98%           
==========================================
  Files              8        8           
  Lines            384      384           
==========================================
  Hits             311      311           
  Misses            73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


<buildtool_depend>cmake</buildtool_depend>

<build_depend>gz-cmake3</build_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker here, but maybe eventually worth adding a key for CLI11 (libcli11-dev) and adding a depend here, since we are currently vendoring, but could probably drop that.

@azeey azeey merged commit fd618d2 into gz-utils2 Apr 17, 2024
11 checks passed
@azeey azeey deleted the package_xml branch April 17, 2024 20:16
@scpeters scpeters mentioned this pull request Jul 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants