Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include file name in log format #144

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 30, 2024

🦟 Bug fix

Fixes gazebosim/gz-common#631

Summary

Based on formatting wiki https://github.com/gabime/spdlog/wiki/3.-Custom-formatting %s is for Basename of the source file and %# is for line number.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from iche033 August 30, 2024 23:39
@azeey azeey merged commit d6c602d into gazebosim:gz-utils3 Sep 3, 2024
11 checks passed
@azeey azeey mentioned this pull request Sep 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants