Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service bridging for ignition services that are not WorldControl? #385

Closed
jwdinius opened this issue Apr 30, 2023 · 2 comments
Closed

Service bridging for ignition services that are not WorldControl? #385

jwdinius opened this issue Apr 30, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jwdinius
Copy link

Desired behavior

#211 added support for bridging services that have a request type of WorldControl. I would like to be able to bridge SetEntityPose as well.

Alternatives considered

Calling the ignition service in an OS process launched within a ROS 2 python node (using subprocess or os package)

Implementation suggestion

Could we not follow the pattern from #211? I'm curious why support for other services was not added at this time, or why an explicit error message was not added when trying to bridge a service that did not have a WorldControl request type. The current implementation keeps blocking even though nothing useful is being done when trying to bridge different service types.

Additional context

@jwdinius jwdinius added the enhancement New feature or request label Apr 30, 2023
@azeey azeey self-assigned this May 1, 2023
@azeey
Copy link
Contributor

azeey commented May 1, 2023

Looks like a duplicate of #363. There's a draft PR mapping EntityPose in #380. I'll go ahead and close this, but feel free to reopen if this is different from #363.

@azeey azeey closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
@MertCecen
Copy link

Is there any updates on this I need to use SetEntityPose but it's just not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants