Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-2794: Make Kerberos support more configurable #3035

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

GCHQDeveloper314
Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 commented Oct 16, 2023

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2a10ef0) 65.18% compared to head (323de20) 65.20%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3035      +/-   ##
=============================================
+ Coverage      65.18%   65.20%   +0.01%     
- Complexity      2632     2634       +2     
=============================================
  Files            904      904              
  Lines          28901    28903       +2     
  Branches        3248     3248              
=============================================
+ Hits           18840    18845       +5     
+ Misses          8596     8595       -1     
+ Partials        1465     1463       -2     
Files Coverage Δ
...ov/gchq/gaffer/accumulostore/utils/TableUtils.java 60.84% <33.33%> (-0.14%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@t92549 t92549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeCov not happy with coverage, but presumably this cannot be tested in unit tests and needs testing in gaffer-docker? Has this been tested manually with gaffer-docker?

@GCHQDeveloper314
Copy link
Member Author

CodeCov not happy with coverage, but presumably this cannot be tested in unit tests and needs testing in gaffer-docker? Has this been tested manually with gaffer-docker?

Yes, this has been confirmed as working as expected. It's not possible to test the Kerberos support with unit/integration tests unfortunately - at least not without substantial changes to Accumulo.

@t92549 t92549 merged commit 90147d3 into develop Oct 26, 2023
23 checks passed
@t92549 t92549 deleted the gh-2794-make-kerberos-support-more-configurable branch October 26, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Kerberos support more configurable
3 participants