Gh-3056: Add testing to GafferPopElementGenerator #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../tinkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferEdgeGeneratorTest.java
Outdated
Show resolved
Hide resolved
...inkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferEntityGeneratorTest.java
Outdated
Show resolved
Hide resolved
...nkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopEdgeGeneratorTest.java
Outdated
Show resolved
Hide resolved
...nkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopEdgeGeneratorTest.java
Outdated
Show resolved
Hide resolved
...erpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopVertexGeneratorTest.java
Outdated
Show resolved
Hide resolved
...erpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopVertexGeneratorTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3070 +/- ##
=============================================
+ Coverage 65.25% 65.30% +0.04%
- Complexity 2637 2643 +6
=============================================
Files 907 907
Lines 28964 28964
Branches 3249 3249
=============================================
+ Hits 18901 18914 +13
+ Misses 8602 8591 -11
+ Partials 1461 1459 -2 ☔ View full report in Codecov by Sentry. |
GCHQDev404
reviewed
Nov 7, 2023
...rpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopElementGeneratorTest.java
Show resolved
Hide resolved
t92549
previously approved these changes
Nov 8, 2023
tb06904
previously approved these changes
Nov 8, 2023
...nkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopEdgeGeneratorTest.java
Outdated
Show resolved
Hide resolved
...nkerpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopEdgeGeneratorTest.java
Outdated
Show resolved
Hide resolved
...erpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopVertexGeneratorTest.java
Outdated
Show resolved
Hide resolved
...erpop/src/test/java/uk/gov/gchq/gaffer/tinkerpop/generator/GafferPopVertexGeneratorTest.java
Outdated
Show resolved
Hide resolved
GCHQDeveloper314
approved these changes
Nov 9, 2023
tb06904
approved these changes
Nov 10, 2023
t92549
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added testing to GafferPopElementGenerator to increase test coverage. Also updated testing from JUnit to AssertJ for the other generator classes to aid with improving assertion readability (#3014). Improved test coverage of GafferPopVertexGenerator and GafferPopEdgeGenerator classes.
Related issue