Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 2839 track creation date of sub graphs #3269

Merged
merged 41 commits into from
Sep 2, 2024

Conversation

wb36499
Copy link
Member

@wb36499 wb36499 commented Aug 20, 2024

  • Adds /config/graphCreatedTime endpoint to retrieve graph creation timestamp associated with REST API
  • Adds operation to retrieve list of all graphIds & associated creation timestamps. In a federated store this will return all sub-graph ids and creations times
  • Adds custom property to Accumulostore on table creation to save graph creation time
  • Saves MapStore based graph creation times as Store variable on build

Related issue

@wb36499 wb36499 linked an issue Aug 20, 2024 that may be closed by this pull request
@wb36499 wb36499 marked this pull request as ready for review August 22, 2024 12:09
@wb36499 wb36499 self-assigned this Aug 22, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (4e15ae1) to head (bc5bdcc).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...gaffer/operation/impl/get/GetGraphCreatedTime.java 90.00% 1 Missing ⚠️
...fer/operation/serialisation/TypeReferenceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3269   +/-   ##
==========================================
  Coverage      67.55%   67.55%           
- Complexity      2591     2595    +4     
==========================================
  Files            927      929    +2     
  Lines          29791    29824   +33     
  Branches        3289     3291    +2     
==========================================
+ Hits           20124    20149   +25     
- Misses          8219     8225    +6     
- Partials        1448     1450    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 added the feature A proposed new feature label Aug 23, 2024
@cn337131 cn337131 added this to the 2.3.1 milestone Aug 23, 2024
@wb36499 wb36499 requested a review from tb06904 August 27, 2024 14:58
Copy link

sonarcloud bot commented Aug 29, 2024

@wb36499 wb36499 merged commit cd93f5e into develop Sep 2, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-2839-track-creation-date-of-sub-graphs branch September 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track creation date of sub graphs
4 participants