Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3274: Simplified federation proof of concept #3275

Merged
merged 12 commits into from
Sep 4, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Aug 29, 2024

This is a basic proof of concept to demonstrate a simpler federated store with a rethink on how merging works and the required classes.

This is not feature complete, the idea is this serves as a base for some additional required features. Once feature complete this may be able to replace the existing federated store to address its issues and technical debt.

Features present:

  • Extendable merge/aggregator classes that support partially lazy element aggregation based on schemas.
  • Ability to add graphs via the stores java methods.
  • Operation handler for delegation to sub graphs (both for operations with and without output).
  • Basic federated handler for merging schemas.
  • Limited unit and integration testing.
  • Ability to pass graph IDs and a toggle for element aggregation via operation options.

@tb06904 tb06904 added feature A proposed new feature federated-store Specific to/touches the federated-store module labels Aug 29, 2024
@tb06904 tb06904 added this to the 2.3.1 milestone Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 73.82550% with 39 lines in your changes missing coverage. Please review.

Project coverage is 67.59%. Comparing base (cd93f5e) to head (03467ff).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...v/gchq/gaffer/federated/simple/FederatedStore.java 70.45% 11 Missing and 2 partials ⚠️
...imple/merge/operator/ElementAggregateOperator.java 71.42% 4 Missing and 4 partials ⚠️
...e/operation/handler/FederatedOperationHandler.java 61.90% 7 Missing and 1 partial ⚠️
...derated/simple/merge/DefaultResultAccumulator.java 63.15% 3 Missing and 4 partials ⚠️
...ted/simple/operation/handler/GetSchemaHandler.java 81.81% 1 Missing and 1 partial ⚠️
...mple/operation/handler/FederatedOutputHandler.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3275      +/-   ##
=============================================
+ Coverage      67.55%   67.59%   +0.03%     
  Complexity      2595     2595              
=============================================
  Files            929      936       +7     
  Lines          29824    29973     +149     
  Branches        3291     3318      +27     
=============================================
+ Hits           20149    20259     +110     
- Misses          8225     8251      +26     
- Partials        1450     1463      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tb06904 tb06904 linked an issue Aug 30, 2024 that may be closed by this pull request
p29876
p29876 previously approved these changes Sep 2, 2024
Copy link
Member

@p29876 p29876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥
Only a couple nitpicks but this is just a PoC so can be left for now if you want

p29876
p29876 previously approved these changes Sep 2, 2024
@j69772 j69772 self-requested a review September 4, 2024 12:57
j69772
j69772 previously approved these changes Sep 4, 2024
@tb06904 tb06904 dismissed stale reviews from j69772 and p29876 via 03467ff September 4, 2024 14:49
Copy link

sonarcloud bot commented Sep 4, 2024

@wb36499 wb36499 merged commit a8b0739 into develop Sep 4, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3274-simple-federation-poc branch September 4, 2024 15:29
rchangy pushed a commit to rchangy/Gaffer that referenced this pull request Sep 7, 2024
* Initial files

* implement basic federated operation execution

* element aggregation based on schema

* simple test case

* tweaks and basic unit tests

* docs and unimplemented method

* add to ci

* typo

* address comments

* Add to legacy CI
@tb06904 tb06904 modified the milestones: 2.3.1, 2.4.0 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A proposed new feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a POC simplified federated store
4 participants