-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3274: Simplified federation proof of concept #3275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3275 +/- ##
=============================================
+ Coverage 67.55% 67.59% +0.03%
Complexity 2595 2595
=============================================
Files 929 936 +7
Lines 29824 29973 +149
Branches 3291 3318 +27
=============================================
+ Hits 20149 20259 +110
- Misses 8225 8251 +26
- Partials 1450 1463 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Only a couple nitpicks but this is just a PoC so can be left for now if you want
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java
Show resolved
Hide resolved
...simple-federated-store/src/main/java/uk/gov/gchq/gaffer/federated/simple/FederatedStore.java
Show resolved
Hide resolved
...re/src/test/java/uk/gov/gchq/gaffer/federated/simple/merge/DefaultResultAccumulatorTest.java
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
* Initial files * implement basic federated operation execution * element aggregation based on schema * simple test case * tweaks and basic unit tests * docs and unimplemented method * add to ci * typo * address comments * Add to legacy CI
This is a basic proof of concept to demonstrate a simpler federated store with a rethink on how merging works and the required classes.
This is not feature complete, the idea is this serves as a base for some additional required features. Once feature complete this may be able to replace the existing federated store to address its issues and technical debt.
Features present: