Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3276: Add ability to seed with Vertex only in Gremlin #3286

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Sep 10, 2024

This should allow users to seed a Gremlin query with a vertex that exists only on an edge and not as an individual entity.

Related issue

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (16fd6a3) to head (d3eaa1c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rpop/process/traversal/util/GafferVertexUtils.java 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3286      +/-   ##
=============================================
+ Coverage      67.73%   67.74%   +0.01%     
  Complexity      2594     2594              
=============================================
  Files            945      946       +1     
  Lines          30160    30179      +19     
  Branches        3329     3331       +2     
=============================================
+ Hits           20428    20445      +17     
- Misses          8267     8268       +1     
- Partials        1465     1466       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 marked this pull request as ready for review September 11, 2024 09:25
@cn337131 cn337131 added this to the 2.3.1 milestone Sep 11, 2024
@cn337131 cn337131 added enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module labels Sep 11, 2024
tb06904
tb06904 previously approved these changes Sep 12, 2024
Copy link

sonarcloud bot commented Sep 13, 2024

@wb36499 wb36499 merged commit a5f59dc into develop Sep 13, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3276-seed-with-vertex-only-gremlin branch September 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature tinkerpop Specific to/touches the tinkerpop module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gremlin does not return vertex without Gaffer entity
4 participants