Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 3288: Store Graphs in cache in federated POC #3289

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Sep 12, 2024

Fairly simple just moves to using the default gaffer cache for storing graphs that have been added to the federated store.

Related issue

@tb06904 tb06904 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Sep 12, 2024
@tb06904 tb06904 added this to the 2.4.0 milestone Sep 12, 2024
@tb06904 tb06904 linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (58ad080) to head (f7b20df).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...v/gchq/gaffer/federated/simple/FederatedStore.java 84.21% 2 Missing and 1 partial ⚠️
...e/operation/handler/FederatedOperationHandler.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3289      +/-   ##
=============================================
- Coverage      67.73%   67.73%   -0.01%     
  Complexity      2594     2594              
=============================================
  Files            945      945              
  Lines          30148    30160      +12     
  Branches        3328     3329       +1     
=============================================
+ Hits           20421    20428       +7     
- Misses          8263     8267       +4     
- Partials        1464     1465       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 12, 2024

@wb36499 wb36499 merged commit 16fd6a3 into develop Sep 13, 2024
26 of 28 checks passed
@wb36499 wb36499 deleted the gh-3288-graphs-in-cache-federated-poc branch September 13, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow storing graphs in cache in federated POC
4 participants